| Summary: | new media spec implementation needs to support STUN | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Sjoerd Simons <sjoerd> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | cmaiku |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/maiku/telepathy-gabble.git;a=shortlog;h=refs/heads/stun | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Sjoerd Simons
2009-11-18 03:31:28 UTC
Some review comments for the branch: * in PROP_STUN_SERVERS to create the ValueArray, use gabble_value_array_build, which will cut out a big chunk of code. * For the test instead of assert X == Y, use the assertEquals method, which generated better error messages on failure * For the test, please factor out the Call specicif test into it's own test function. Also the code that checks the result of the stun check, should just be a function as currently it jsut seems copy/pasted. * Also instead of doing, assert stream_props['Transport'] == 2 # GTALK_P2P use a constant from constants.py (if there isn't one for it, please add one) Updated the branch per your review. 443dd549dfb24393975e7f345cb5f5540ff42313: assertEquals is (expected, value), not (value, expected).. which seems to catch everyone by surprise. Updated the branch per your review. Merged, thanks |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.