Bug 25206

Summary: Xorg crash when closing down appgroup process
Product: xorg Reporter: Rich Coe <Richard.Coe>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium Keywords: patch
Version: 7.4 (2008.09)   
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Xext/appgroup.c patch
none
xltest test script to launch test
none
test script called by xltest
none
xlaunch appgroup session leader program none

Description Rich Coe 2009-11-20 13:55:40 UTC 
Created attachment 31354 [details] [review]
Xext/appgroup.c patch

The Xorg server crashes when closing down an appgroup process.

The appgroup leader has closed down and one or more windows from the appgroup
session are left open.  When the remaining window(s) are closed, the Xorg
server
crashes (sometimes).

Caused when windows in the appgroup are not correctly inserted into the
appgroup
list at window create due to a coding error. 

Reproducible: Always

Steps to Reproduce:
1. compile the xlaunch program to allow creation of appgroup sessions
2. run xltest script
3. close any leaked xterm's created by the script
Actual Results:  
up to 20 xterms are opened and one or more windows are left running 
when the appgroup leader exits.  Xorg server crashes when closing remaining
xterm windows.

Expected Results:  
up to 20 xterms are opened and then get closed each
Comment 1 Rich Coe 2009-11-20 13:56:43 UTC 
Created attachment 31355 [details]
xltest test script to launch test
Comment 2 Rich Coe 2009-11-20 13:57:22 UTC 
Created attachment 31356 [details]
test script called by xltest
Comment 3 Rich Coe 2009-11-20 13:58:48 UTC 
Created attachment 31357 [details]
xlaunch appgroup session leader program

compile with 
cc -g -o xlaunch xlaunch.o -lXau -lXext -lXt -lX11
Comment 4 Julien Cristau 2009-11-28 15:41:43 UTC 
The appgroup code has been removed in xserver 1.6:

commit eafaf40fb3368ca7e4cf48336fdb7a6c9f536bfa
Author: Adam Jackson <ajax@redhat.com>
Date:   Fri Apr 18 18:50:05 2008 -0400

    Death to APPGROUP.

Thanks for the patch though.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.