Bug 25341

Summary:	Always sets its own vcard on login
Product:	Telepathy	Reporter:	Sjoerd Simons <sjoerd>
Component:	gabble	Assignee:	Will Thompson <will>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	high	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/andrunko/telepathy-gabble.git;a=shortlog;h=refs/heads/fd.o%2325341
Whiteboard:	review+
i915 platform:		i915 features:

Description Sjoerd Simons 2009-11-29 06:43:21 UTC

On login gabble retrieves its own vcard to grab some information out of it, unfortunately it still always sets it's own vcard too even though nothing changed. Wasting bandwidth and potentially causing openfire to oom... 

see http://www.igniterealtime.org/issues/browse/OF-82 for information about the openfire issue.

Comment 1 Andre Moreira Magalhaes 2009-12-07 06:18:45 UTC

Added patch that attempts to fix the bug.

Note that some servers (gmail for example) do not store the full vcard, only some subset of it, so this patch may not work in this case.

gmail for example only store FN and PHOTO vcard fields, but empathy tries to set the NICKNAME field every time it logs in, so the vcard will be set on login when using gmail servers

Comment 2 Will Thompson 2009-12-10 04:48:35 UTC

Pointing URL at complete branch.

Comment 3 Will Thompson 2009-12-10 04:57:28 UTC

Ideally there'd be a test for this... but it looks like it should work.

Comment 4 Will Thompson 2009-12-15 11:29:30 UTC

Added a test and merged to master and 0.8; will be in 0.9.3 and 0.8.10.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.