Bug 25421

Summary:	various build-system badgering
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-qt	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-qt4-smcv.git;a=shortlog;h=refs/heads/buildsys
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	25422

Description Simon McVittie 2009-12-03 13:31:20 UTC

<http://git.collabora.co.uk/?p=user/smcv/telepathy-qt4-smcv.git;a=shortlog;h=refs/heads/buildsys> has:

* a bugfix for distcheck, which would sometimes fail because Mission Control gets service-activated instead of the fake AccountManager (if you have, e.g., telepathy-mission-control-5 >= 5.3.2-2 on Debian)

* a bugfix for qt4-constants-gen.py to cope with Unicode spec too (from the "we love Unicode" department)

* options on the codegen scripts to change the codegen macro to use

Explanation of the last: TELEPATHY_QT4_EXPORT is inappropriate for use by any project other than telepathy-qt4, because it expands to Q_DECL_IMPORT, which differs from Q_DECL_EXPORT on Windows, if you're not in the telepathy-qt4 tree. This will make our codegen tools more re-usable - third-party projects that extend telepathy-qt4 can define THIRD_PARTY_THING_EXPORT in a similar way, and use that.

Also, TELEPATHY_QT4_EXPORT is inappropriate for use by hidden internal codegen, such as the stuff I'm about to file a bug for :-)

Comment 1 Andre Moreira Magalhaes 2009-12-03 14:04:00 UTC

(In reply to comment #0)
> <http://git.collabora.co.uk/?p=user/smcv/telepathy-qt4-smcv.git;a=shortlog;h=refs/heads/buildsys>
> has:
> 
> * a bugfix for distcheck, which would sometimes fail because Mission Control
> gets service-activated instead of the fake AccountManager (if you have, e.g.,
> telepathy-mission-control-5 >= 5.3.2-2 on Debian)
> 
> * a bugfix for qt4-constants-gen.py to cope with Unicode spec too (from the "we
> love Unicode" department)
> 
> * options on the codegen scripts to change the codegen macro to use
> 
> Explanation of the last: TELEPATHY_QT4_EXPORT is inappropriate for use by any
> project other than telepathy-qt4, because it expands to Q_DECL_IMPORT, which
> differs from Q_DECL_EXPORT on Windows, if you're not in the telepathy-qt4 tree.
> This will make our codegen tools more re-usable - third-party projects that
> extend telepathy-qt4 can define THIRD_PARTY_THING_EXPORT in a similar way, and
> use that.
> 
> Also, TELEPATHY_QT4_EXPORT is inappropriate for use by hidden internal codegen,
> such as the stuff I'm about to file a bug for :-)
> 
++ Please merge it

Comment 2 Simon McVittie 2009-12-04 04:20:43 UTC

Fixed in 0.9.2

Comment 3 Simon McVittie 2009-12-04 04:25:01 UTC

Oops, too fast; I mistook this for one of the tp-glib bugs I was dealing with. I meant to say: fixed in git, will be in 0.2.1 or 0.3.0.

(I think we're due for a release soon, because the Qt 4.6 thing is likely to bite people; we should release a 0.2.1 probably. I'll have another look at the docs bug so we can include that if it's ready.)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.