| Summary: | /usr/lib/pm-utils/functions: is_set missing '|' | ||
|---|---|---|---|
| Product: | pm-utils | Reporter: | profjim |
| Component: | General | Assignee: | Victor Lowther <victor.lowther> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | blocker | ||
| Priority: | highest | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | patch to revert above patch to fix regression | ||
Yes, they should be. Thanks! rc2 has a major regression: debugging is now always on, and suspend does not work at all any more. The reason is commit f7df23f2928f63c38ef4b307b4312787f1a715bc (which supposedly fixed this bug), but since it essentially reverts the implied value of unspecified variables, it turns the behaviour upside down. So far the code has been written with the assumption that is_set() returns 2 (and not 0) for undefined variables, so before the default value of variables can be true, the entire code would need to change first. Attached patch reverts to the original behaviour for now, and makes pm-suspend & friends work again. Created attachment 31971 [details] [review] patch to revert above patch to fix regression (In reply to comment #3) > Created an attachment (id=31971) [details] > patch to revert above patch to fix regression > Remember kids, don't release code under the influence of sleep deprivation! Thanks, this was fixed in git now. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
/usr/lib/pm-utils/functions: is_set() says: > # If a variable is set to true, yes, 1, or is simply set with no value, > # return 0, otherwise return 1. > is_set() { > case ${1-UNSET} in > true|yes|TRUE|YES|on|ON|1'') return 0;; if 1 and '' are supposed to be two different ways of getting retvalue 0, shouldn't they be separated with a '|'?