Bug 25440

Summary:	PATCH: fixes conflicting miptree definitions
Product:	Mesa	Reporter:	Bob Gleitsmann <rjgleits>
Component:	Drivers/DRI/nouveau	Assignee:	Nouveau Project <nouveau>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	git
Hardware:	x86-64 (AMD64)
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch to fix problem above

Description Bob Gleitsmann 2009-12-04 02:35:51 UTC

Created attachment 31731 [details] [review]
Patch to fix problem above

There is a conflict between the definitions of struct nv50_miptree and nv[1-4]0_miptree + nv04_miptree. Note that nv50_miptree starts with struct nouveau_miptree. Sometimes pipe_textures are cast to nouveau_miptree, although the pt was part of a nv40_miptree (for example). This results in the bo field pointing to an incorrect location, resulting in segfaults, etc. The patch does not change the nv50 driver (or shouldn't). I have tested it on 7300 GT only. 

Best Wishes,

Bob Gleitsmann

Comment 1 Younes Manton 2009-12-06 09:36:42 UTC

Thanks. I came across this too and someone pointed me to this patch. We should go back and clean this up so that all the drivers use the same base for miptrees, but in the meantime I'll apply this as a workaround. Thanks again.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.