| Summary: | [transet] Gentoo QA Notice: incompatible implicit declaration of built-in function 'memcpy' | ||
|---|---|---|---|
| Product: | xorg | Reporter: | walch.martin |
| Component: | App/other | Assignee: | Keith Packard <keithp> |
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | minor | ||
| Priority: | medium | Keywords: | patch |
| Version: | git | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| Whiteboard: | 2011BRB_Reviewed | ||
| i915 platform: | i915 features: | ||
Triaging. Should this just be closed? Where is this even located? Google says you're partially to blame, Keith, so over to you to do with or close as you like. (In reply to comment #2) > Where is this even located? http://webcvs.freedesktop.org/xapps/transset/ Transset has now been added to the xorg/apps git repos. Problem 1 was fixed in the import of changes from Daniel Forchheimer: http://cgit.freedesktop.org/xorg/app/transset/commit/?id=470ea5431ffe0a54995c93506ab5e55ce534e039 Problem 2 was still in the code - I've pushed a fix for it to git now: http://cgit.freedesktop.org/xorg/app/transset/commit/?id=0e08633cb33874840915db81b8c11503ec9efa0c |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
When installing transset on Gentoo (amd64), portage complains about a compiler warning (gcc 4.4.2): QA Notice: Package has poor programming practices which may compile fine but exhibit random runtime failures. * transSet.c:68: warning: incompatible implicit declaration of built-in function 'memcpy' This seems to be resolved easily with an additional include of string.h: --- a/transSet.c 2009-12-09 22:05:07.000000000 +0100 +++ b/transSet.c 2009-12-09 22:05:07.000000000 +0100 @@ -13,6 +13,7 @@ #include <X11/Xatom.h> #include "dsimple.h" #include <stdlib.h> +#include <string.h> Window target_win; There is another compiler warning (without Gentoo QA notice) in dsimple.c: dsimple.c: In function 'Window_With_Name': dsimple.c:478: warning: comparison between signed and unsigned integer expressions This one also seems to have a simple fix --- a/dsimple.c 2009-12-09 22:10:02.000000000 +0100 +++ b/dsimple.c 2009-12-09 22:11:26.000000000 +0100 @@ -464,8 +464,7 @@ char *name; { Window *children, dummy; - unsigned int nchildren; - int i; + unsigned int i, nchildren; Window w=0; char *window_name;