Bug 25658

I guess I should add that I'm using KMS and X.  Suspend without starting X does still work.

What disk partition does nouveau leave firmware on or is it built into initrd?

If the partition containing firmware isnt mounted when nouveau tries
to reload on resume wont there be problems?

On Wed, Dec 16, 2009 at 8:27 AM,  <bugzilla-daemon@freedesktop.org> wrote:
> http://bugs.freedesktop.org/show_bug.cgi?id=25658
>
>
>
>
>
> --- Comment #1 from Tavian Barnes <tavianator@gmail.com>  2009-12-15 11:27:43 PST ---
> I guess I should add that I'm using KMS and X.  Suspend without starting X does
> still work.
>
>
> --
> Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
>

(In reply to comment #2)
> What disk partition does nouveau leave firmware on or is it built into initrd?
> 
> If the partition containing firmware isnt mounted when nouveau tries
> to reload on resume wont there be problems?
> 

The firmware is in /lib/firmware/nouveau on both my root partition and the initrd.  But I don't think that's the issue anyway, since it never suspends in the first place; it just sits there blinking.  I'm wondering if there was a mistake in extracting the firmware from the C source, or if there's something broken about the firmware interface and suspend.  Does it work with other (non-NV92) cards?

I also suspected loadable firmware initially, but then I quickly moved to suspecting all the ttm changes.
It's the last merge that broke it for me :
commit 12b59e64a4df9f4298a2abb8b331074adea113ed

curro pointed me to the following fix on dri-devel by airlied :
http://www.mail-archive.com/dri-devel@lists.sourceforge.net/msg45533.html

It seems that fixed suspend for me. But I still have troubles resuming, I get pixmap corruption problem in X. After reloading X, it is fine.

However, there is also a known bug in nouveau code, fixed by curro :
http://lists.freedesktop.org/archives/nouveau/2009-December/004266.html

This last patch seems to correct a very obvious bug/overlook. But it causes other problems for me when resuming :
Dec 15 18:50:06 xps-m1530 kernel: [   42.706924] [drm] nouveau 0000:01:00.0: Reinitialising engines...
Dec 15 18:50:06 xps-m1530 kernel: [   42.709976] [drm] nouveau 0000:01:00.0: Restoring GPU objects...
Dec 15 18:50:06 xps-m1530 kernel: [   42.742509] [drm] nouveau 0000:01:00.0: Restoring mode...
Dec 15 18:50:06 xps-m1530 kernel: [   42.742513] [drm] nouveau 0000:01:00.0: bo ffff88011d2b1400 pinned elsewhere: 0x00000002 vs 0x00000004
Dec 15 18:50:06 xps-m1530 kernel: [   42.746882] [drm] nouveau 0000:01:00.0: bo ffff88011d2b1400 pinned elsewhere: 0x00000002 vs 0x00000004
Dec 15 18:50:06 xps-m1530 kernel: [   42.746885] [drm:drm_helper_resume_force_mode] *ERROR* failed to set mode on crtc ffff88011c51c000

The screen stays black. Reloading nouveau blindly fixes it though.
Some other times, resuming caused hardlock, but I suspect it's related to this same bo/ttm problem.

Just give me another year and I might find something :)

(In reply to comment #4)
> I also suspected loadable firmware initially, but then I quickly moved to
> suspecting all the ttm changes.

That occurred to me too actually, but for some reason there's no nouveau module when you check out the commits that got merged, so I couldn't properly bisect it.  I guess I could just add the nouveau code back myself and then compile.

> It's the last merge that broke it for me :
> commit 12b59e64a4df9f4298a2abb8b331074adea113ed
> 
> curro pointed me to the following fix on dri-devel by airlied :
> http://www.mail-archive.com/dri-devel@lists.sourceforge.net/msg45533.html
> 
> It seems that fixed suspend for me. But I still have troubles resuming, I get
> pixmap corruption problem in X. After reloading X, it is fine.
> 
> However, there is also a known bug in nouveau code, fixed by curro :
> http://lists.freedesktop.org/archives/nouveau/2009-December/004266.html
> 
> This last patch seems to correct a very obvious bug/overlook. But it causes
> other problems for me when resuming :
> Dec 15 18:50:06 xps-m1530 kernel: [   42.706924] [drm] nouveau 0000:01:00.0:
> Reinitialising engines...
> Dec 15 18:50:06 xps-m1530 kernel: [   42.709976] [drm] nouveau 0000:01:00.0:
> Restoring GPU objects...
> Dec 15 18:50:06 xps-m1530 kernel: [   42.742509] [drm] nouveau 0000:01:00.0:
> Restoring mode...
> Dec 15 18:50:06 xps-m1530 kernel: [   42.742513] [drm] nouveau 0000:01:00.0: bo
> ffff88011d2b1400 pinned elsewhere: 0x00000002 vs 0x00000004
> Dec 15 18:50:06 xps-m1530 kernel: [   42.746882] [drm] nouveau 0000:01:00.0: bo
> ffff88011d2b1400 pinned elsewhere: 0x00000002 vs 0x00000004
> Dec 15 18:50:06 xps-m1530 kernel: [   42.746885]
> [drm:drm_helper_resume_force_mode] *ERROR* failed to set mode on crtc
> ffff88011c51c000
> 
> The screen stays black. Reloading nouveau blindly fixes it though.
> Some other times, resuming caused hardlock, but I suspect it's related to this
> same bo/ttm problem.

Similarly for me, except I get a BUG on resume.  No black screen though; I could see the BUG perfectly.  I can reproduce it and write down what it said if it's important.  I'll try with the dri-devel patch next.

> Just give me another year and I might find something :)

Haha.  Yeah, to me that nouveau bug you mentioned was about the least obvious "obvious" bug I've ever seen.  I really should read up on driver programming.

Latest nouveau git should fix the issues mentioned here.

(In reply to comment #6)
> Latest nouveau git should fix the issues mentioned here.

Indeed it does, thanks.  I noticed the slew of new commits right after my last comment.

The bad side effects of curro's patch were apparently fixed by :
    drm/nouveau: fix bug causing pinned buffers to lose their NO_EVICT flag

So all is well.. almost :)
There are still some corruption in X after resuming, but it is significantly less bad than before (when I had only airlied ttm fix, and not the nouveau ones).
Now the corruptions seem to be mostly font/cursor related.

I have screenshot of the corrupted fonts, but the screenshot of the wrong cursor looks right.