Bug 25684

Summary:	crash when adding two similar IRC nicks
Product:	Telepathy	Reporter:	Jani Monoses <jani>
Component:	mission-control	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	guillaume.desmottes, smcv, vivek
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-mission-control-smcv.git;a=shortlog;h=refs/heads/trivia
Whiteboard:
i915 platform:		i915 features:
Attachments:	a fix

Description Jani Monoses 2009-12-17 02:50:24 UTC

Created attachment 32142 [details] [review]
a fix

When importing pidgin accounts using empathy and MC5 git head, having two IRC accounts with the same nick but on different networks causes a naming conflict.

The original empathy bug report
https://bugzilla.gnome.org/show_bug.cgi?id=598549

The attahced patch fixes it for me. (apparently now the keyfile group that is checked for existence is not the same as the one written)

Comment 1 Jani Monoses 2010-04-22 03:52:30 UTC

I think this patch will not apply anymore as the unique naming code that it touches moved to another file.

Comment 2 Simon McVittie 2010-05-25 10:14:42 UTC

*** Bug 26714 has been marked as a duplicate of this bug. ***

Comment 3 Simon McVittie 2010-05-25 10:17:03 UTC

I applied Jani's fix in the right place (which has moved to another file since this bug was reported), and added a regression test. See my trivia branch.

This doesn't seem to affect the 5.4 stable branch (I backported the regression test).

Comment 4 Guillaume Desmottes 2010-05-26 01:41:20 UTC

trivia branch looks good except that the doc in tests/README doesn't work for me:


cassidy@cass-x200s:~/dev/telepathy-mission-control $ make -C test/twisted check-twisted TWISTED_BASIC_TESTS= TWISTED_SEPARATE_TESTS=dispatcher/create-at-startup.py
bash: make -C test/twisted check-twisted: No such file or directory

Comment 5 Simon McVittie 2010-05-28 03:05:13 UTC

Should be fixed in 5.5.0; doesn't affect 5.4.x (but I added the regression test to 5.4.x too, just to be sure).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.