Bug 25695

Created attachment 32320 [details] [review]
patch

While GTK+ and Qt3 versions of toolbars (uim-toolbar-gtk and uim-toolbar-qt) shrink when I double-click the left edge of the toolbar, the Qt4 version of a toolbar (uim-toolbar-qt4) doesn't. This attachment fixes this bug in the Qt4 version, though uim-toolbar-qt4 stretches on focus change as the other versions do.

Implemented in the master branch.

http://code.google.com/p/uim/source/detail?r=4670a75cc53e29660ac61a1877f6bd084fe8e314
http://code.google.com/p/uim/source/detail?r=58cfcf99bca0190d30100dcc4629bbfcdd613e7c

You can enable this feature with uim-pref-qt4, uim-pref-gtk2, uim-pref-gtk3 or uim-pref-qt.

Created attachment 58320 [details]
screencast showing toolbar hiding behavior

I cloned and built git master fresh as of Mar 12 (f78a3a5b), and this toolbar hiding fix doesn't seem to work well and has bad side effects. I don't know if I'm allowed to change the status to REOPENED, but I think it should be.

I'm now using UIM with both Anthy for Japanese and m17n for Hindi phonetic input. If I set the Qt4 panel to display depending on mode (in the preferences), it will still show when I choose direct input -- but hide when I change to m17n. Please see the attached screencast (ogv). Apologies for its large size.

Related to this is that m17n defaults to "off" when changing to it, and this can't be changed -- the m17n module doesn't seem to be configurable at all (?). From what I can tell, there are no unconfigurable hardcoded shortcuts to toggle it on/off either. The result is that it starts as "off", and you can't enable it via keyboard, nor can you enable it via the invisible toolbar. In summary, m17n (at least with Hindi input) ends up being unusable with this toolbar mode in its current implementation. (As a workaround the on/off default can be changed by manually editing m17nlib.scm.)

Likely the input property string for the m17n input matches the fields[1] == "off" check in qt4/toolbar/common-uimstateindicator.cpp:189.
> if ( !isHidden && (fields[1] == "off"
>     || fields[1].endsWith( "_direct" ) ) ) {
>     isHidden = true;
> }

I'm not sure that first fields[1] test is wise, but then again I haven't used any of the other methods for other languages. Obviously something seems wrong with the second too (endsWith("_direct")) as the toolbar still displays for direct input.

(Some of the m17n bits should maybe be filed as new bugs (no shortcuts, defaults to off, etc), but this bug makes those much worse. Editing m17nlib.scm to make m17n start as "on" certainly helps.)

Created attachment 58682 [details] [review]
patch to change behavior of toolbar

I might misunderstand what you said.

With the attached patch,
 * a toolbar doesn't hide with the m17n input regardless of its mode
 * a toolbar hides with the direct input

Is this what you want?

(In reply to comment #4)
> Created attachment 58682 [details] [review] [review]
> patch to change behavior of toolbar
> 
> I might misunderstand what you said.
> 
> With the attached patch,
>  * a toolbar doesn't hide with the m17n input regardless of its mode
>  * a toolbar hides with the direct input
> 
> Is this what you want?

applied the patch above to the master and the 1.8 branch.