Bug 25703

Summary: PROP_ACTIVE used for 2 different properties in ck-session.c
Product: ConsoleKit Reporter: Jonathan Conder <jonno.conder+bugs>
Component: DaemonAssignee: william.jon.mccann
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Jonathan Conder 2009-12-18 03:07:04 UTC
Hi, I was just browsing through the ConsoleKit source to find out what an 'active' session is and how they work. Anyway I just noticed this call in ck-session.c:

g_object_class_install_property (object_class,
                                 PROP_ACTIVE,
                                 g_param_spec_boolean ("idle-hint",
                                                       NULL,
                                                       NULL,
                                                       FALSE,
                                                       G_PARAM_READWRITE));

but it should be:

g_object_class_install_property (object_class,
                                 PROP_IDLE_HINT,
                                 g_param_spec_boolean ("idle-hint",
                                                       NULL,
                                                       NULL,
                                                       FALSE,
                                                       G_PARAM_READWRITE));

Hopefully this can be fixed quickly :). Thanks
Comment 1 william.jon.mccann 2010-01-28 15:26:07 UTC
Eek.  Nice catch!  Thanks!

commit 42315147af68f5e64f86d794061e8c03e2b8dc01
Author: William Jon McCann <jmccann@redhat.com>
Date:   Thu Jan 28 18:24:49 2010 -0500

    Use the correct property ID for idle-hint
    
    https://bugs.freedesktop.org/show_bug.cgi?id=25703

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.