Bug 25715

17:53 < fledermaus> smcv: trivial point I've noticed, coprights need to be 
                    updated to 2010 rather than 2009 (I guess, unless you 
                    really did write it all last year)
...
17:54 < smcv> fledermaus: I did originally write it all in 2009 (see the git 
              history!), although it's been rebased since

ooi, why cache the account path in a separate property if we're 
also keeping the account?

---

@@ -137,8 +137,8 @@ _mcd_plugin_request_class_init (
 
   g_object_class_install_property (object_class, PROP_REAL_REQUEST,
       g_param_spec_object ("real-request", "Real channel request",
-          "The underlying McdChannel",
-          MCD_TYPE_CHANNEL,
+          "The underlying McrRequest",
+          MCD_TYPE_REQUEST,

Typo - McdRequest I assume

---

+_mcd_request_set_success (McdRequest *self)
⋮
+      DEBUG ("Ignoring an attempt to fail after already complete");

typo in DEBUG - attempt to succeed?

r-, but only trivia

(In reply to comment #2)
> ooi, why cache the account path in a separate property if we're 
> also keeping the account?

It's not *cached* separately - we get it from the McdAccount in the getter implementation.

The rationale for having it be a separate property is that when the McdRequest becomes the thing we export on D-Bus to represent the request, we'll use the account-path property as the getter for the D-Bus property. I'll do that in a subsequent branch.

I think this is ready for re-review; the changes are since the merge from master (which didn't require any intervention).

Looks good.

Fixed in git for 5.5.4