Bug 25923

Summary:	gabbletest.py make_result_iq() helper function should not automatically copy query
Product:	Telepathy	Reporter:	Nicolas Dufresne <nicolas>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	minor
Priority:	low
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Nicolas Dufresne 2010-01-06 14:00:02 UTC

In gabbletest.py, the make_result_iq() help function automatically copy the query node of the originating stanza and put it in the result stanza. This behavior is required in very specific cases, not the general case.

Solutions could be to get this behavior on a boolean set to True or just remove it from this function. Also, I'm pretty sure some tests does not need this node, but most of the time extra nodes are just ignores, so it does not cause trouble here. A review of the tests will be required.

Comment 1 Nicolas Dufresne 2010-01-06 14:36:32 UTC

I spoke a bit too fast, most result do have the same first node as the query. I think I'll propose to add a boolean parameters to disable creation of first node, so we can use this function with google mail notification spec and keep the rest of the code as-is. Citing daf:

"I think it's a bit ugly, but I guess I don't have a better solution right now"

Comment 2 Nicolas Dufresne 2010-03-02 11:01:18 UTC

Was pushed along with email-notification.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.