Bug 26002

Summary:	Increase required telepathy-glib version, for ContactCapabilities
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-qt	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	dariusz.mikulski
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-qt4-smcv.git;a=commitdiff;h=c396589f14f7dbe880195a9638bd14c3a8cb8804
Whiteboard:
i915 platform:		i915 features:
Attachments:	Increasing telepathy-glib version for tests building

Description Simon McVittie 2010-01-12 03:55:49 UTC

I'm told that telepathy-qt4 fails to compile in Maemo 5 - configure finds telepathy-glib, but then the Maemo 5 version of telepathy-glib (0.7.35) is too old to build all the tests.

The solution is to increase the required version of telepathy-glib in configure.ac; when building on Maemo 5, configure will notice that telepathy-glib is too old and skip it, and the tests that need it just won't get compiled.

(The required version for ContactCapabilities is 0.7.37, but it seems reasonable to claim that the 0.8.0 stable release is necessary.)

Comment 1 Dariusz Mikulski 2010-01-12 05:17:31 UTC

Created attachment 32588 [details] [review]
Increasing telepathy-glib version for tests building

Comment 2 Simon McVittie 2010-01-12 05:25:35 UTC

The given patch (bumping the requirement to 0.7.36) is not correct, although it happens to "fix" builds on Maemo 5. From telepathy-glib NEWS:

> telepathy-glib 0.7.37 (2009-09-14)
> ==================================
[...]
> * Update to telepathy-spec 0.17.28
>  * add ContactCapabilities interface

so the unit tests will not compile correctly against telepathy-glib 0.7.36. Please depend on either 0.7.37, or the stable version 0.8.0 (which is basically the same as 0.7.37, in practice).

Comment 3 Simon McVittie 2010-01-12 05:33:44 UTC

Patch in git in my 'build' branch.

Comment 4 Simon McVittie 2010-01-12 05:39:03 UTC

Fixed in git, will be in 0.2.2 (if released) or 0.3.0 (otherwise); thanks to andrunko for review.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.