Bug 26055

Summary:	Improve CanActivateSessions for OpenSolaris
Product:	ConsoleKit	Reporter:	Halton Huo <halton.huo>
Component:	Daemon	Assignee:	william.jon.mccann
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	medium	CC:	brian.cameron
Version:	unspecified
Hardware:	Other
OS:	Solaris
Whiteboard:
i915 platform:		i915 features:
Attachments:	Enhancement CanActivateSessions for OpenSolaris Enhancement CanActivateSessions for OpenSolaris Rewrite to avoid lots of ifdef based on Ray's review

Description Halton Huo 2010-01-14 21:40:31 UTC

VT is always enabled on Linux, on Solaris and OpenSolaris it is not true always.

VT can be on and off by running 
# svcadm enable vtdaemon
# svcadm disable vtdaemon

Now CanActivateSessions return TRUE if the seat is static. I'd say on Solaris, it should also check whether the service vtdaemon is online.

Comment 1 Halton Huo 2010-01-14 22:11:46 UTC

Created attachment 32651 [details] [review]
Enhancement CanActivateSessions for OpenSolaris

Comment 2 Halton Huo 2010-05-18 04:47:16 UTC

Created attachment 35724 [details] [review]
Enhancement CanActivateSessions for OpenSolaris

Comment 3 Halton Huo 2010-05-18 21:53:51 UTC

Created attachment 35746 [details] [review]
Rewrite to avoid lots of ifdef based on Ray's review

Based on Ray's review the patch - http://lists.freedesktop.org/archives/consolekit/2010-May/000086.html - I rework the patch with solution #2.

Comment 4 Ray Strode [halfline] 2010-05-19 08:00:29 UTC

Comment on attachment 35746 [details] [review]
Rewrite to avoid lots of ifdef based on Ray's review

seems fine

Comment 5 Halton Huo 2010-05-19 19:53:07 UTC

Commit into master as http://cgit.freedesktop.org/ConsoleKit/commit/?id=b8a961f91105df661957f6b86922f744bac8b91c

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.