Bug 26147

Summary: telepathy-butterfly crashed with AssertionError in send()
Product: Telepathy Reporter: Cristian Aravena <caravena>
Component: butterflyAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: olivier
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/jonny/telepathy-butterfly.git;a=shortlog;h=refs/heads/26147
Whiteboard: review+
i915 platform: i915 features:

Description Cristian Aravena 2010-01-20 19:34:46 UTC
Open bug en launchpad.net
https://bugs.edge.launchpad.net/ubuntu/+source/telepathy-butterfly/+bug/430768

In comment:
https://bugs.edge.launchpad.net/ubuntu/+source/telepathy-butterfly/+bug/430768/comments/7

"I have this error when switching status too. Also when using the "Quit" option from the Empathy menu"
Comment 1 Jonny Lamb 2010-04-09 11:11:35 UTC
A butterfly log would be pretty useful.
Comment 2 Sebastien Bacher 2010-04-15 14:18:03 UTC
ubuntu bug comment

"http://launchpadlibrarian.net/44259259/butterfly.log
http://launchpadlibrarian.net/44259263/empathy.log
http://launchpadlibrarian.net/44259264/mission-control.log

Here you are, I saved all logs.

The crash happens when the internet connection is lost.
...
http://launchpadlibrarian.net/44282269/butterfly.txt
log with stack trace"
Comment 3 Jonny Lamb 2010-04-16 03:44:58 UTC
Okay, that log was pretty useful and shows what's wrong with the SHA1D. Here is msn object XML:

<msnobj Creator="example@hotmail.com" Size="19086" Type="3" Location="TFRlgrTEF.dat" Friendly="SQBtAGEAZwBlAG4AIAAxADAAAAA=" SHA1D="1h Jo825av2d/RagyNCPI0V3rTs=" SHA1C="VK4lMv5Ori9LfY1J6THi4o/sOAU="/>

Take the SHA1D attribute:

    SHA1D="1h Jo825av2d/RagyNCPI0V3rTs="

I've no idea what that "1h", but we need to work around it. I had a little look at the other MSN implementations and couldn't find anything about this. I'll cook up a patch.
Comment 4 Jonny Lamb 2010-04-16 03:47:49 UTC
Oh, also, the rogue string isn't always first in the SHA1D attribute:

% grep "Invalid SHA1" butterfly-log.txt
papyon/papyon.p2p-WARNING: 14/04/10 18:16:26.809406: Invalid SHA1D in MSNObject: /IkRrvJpPvK/ZFEZEM7eRhle k4=
papyon/papyon.p2p-WARNING: 14/04/10 18:16:27.35620: Invalid SHA1D in MSNObject: 1h Jo825av2d/RagyNCPI0V3rTs=
papyon/papyon.p2p-WARNING: 14/04/10 19:18:38.737390: Invalid SHA1D in MSNObject: 1h Jo825av2d/RagyNCPI0V3rTs=
papyon/papyon.p2p-WARNING: 14/04/10 19:20:31.38971: Invalid SHA1D in MSNObject: 1h Jo825av2d/RagyNCPI0V3rTs=

:-(
Comment 5 Jonny Lamb 2010-04-16 03:49:36 UTC
Please ignore the previous two comments, they should have gone on bug #27672. Sorry.
Comment 6 Jonny Lamb 2010-04-16 04:54:27 UTC
I wrote a patch to work around this. Check it out.
Comment 8 Jonny Lamb 2010-04-19 14:48:42 UTC
(In reply to comment #7)
> git:
> http://git.collabora.co.uk/?p=user/jonny/telepathy-butterfly.git;a=commit;h=ab368c248e95f731abe163f6afc259d97d083779

Yes, my branch (which is a more reliable bookmark) is linked to in the URL field.
Comment 9 Jonny Lamb 2010-04-20 09:34:36 UTC
Cristian, please don't close bugs which aren't actually fixed. I've written the said patch, but it has not been reviewed yet, and as a result, has not been merged upstream. Closing bugs prematurely will mean this bug isn't actually fixed, and we (the developers) will lose track of the bug and patch.
Comment 10 Jonny Lamb 2010-05-03 08:46:43 UTC
*** Bug 27946 has been marked as a duplicate of this bug. ***
Comment 11 Jonny Lamb 2010-05-03 08:47:13 UTC
*** Bug 27932 has been marked as a duplicate of this bug. ***
Comment 12 Olivier Le Thanh Duong 2010-05-21 06:59:46 UTC
Merged, this fix is available in butterfly 0.5.10

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.