Bug 26155

Summary:	Set fatal criticals
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	haze	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	will
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/haze-smcv.git;a=commitdiff;h=refs/heads/fatality
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2010-01-21 04:21:36 UTC

telepathy-glib used to make critical warnings fatal for CMs (Bug #14603). Versions >= 0.9.3 will not do this, so if we want the code-quality benefits of treating these warnings as fatal, we should enable that specifically in each CM where it's relevant.

In Haze's case, we need to be careful about what's critical and what isn't, since some of libpurple is apparently quite critical-happy.

(WONTFIX is an acceptable resolution for this bug if that's the maintainers' considered opinion.)

Comment 1 Simon McVittie 2010-11-30 10:12:26 UTC

I fixed this while debugging the TpBaseContactList branch of Haze.

Comment 2 Simon McVittie 2010-12-01 02:47:39 UTC

r+ from Jonny on IRC, fixed in git for 0.5.0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.