| Summary: | Tubes tests fail assertion about RequestableChannelClasses | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | major | ||
| Priority: | high | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Fixed in git; did not affect a release, AIUI |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
With current master (5b5e88df16ac072f9119991f1e143e84268db540) I'm getting assertion failures in 5 tubes tests, all apparently because RequestableChannelClasses doesn't have the contents these tests want. The assertion that fails is tests/twisted/tubes/tubetestutil.py:89: # muc tubes channel (old API) assert ({cs.CHANNEL_TYPE: cs.CHANNEL_TYPE_TUBES, cs.TARGET_HANDLE_TYPE: cs.HT_ROOM, }, [cs.TARGET_HANDLE, cs.TARGET_ID ] ) in properties.get('RequestableChannelClasses'),\ properties['RequestableChannelClasses'] This appears to be because Tubes ROOM channels now have ChannelType in the allowed properties as well as in the fixed properties, which doesn't make sense. This, in turn, seems to be because the array of allowed properties isn't correctly NULL-terminated. Patch soon.