Bug 26178

Summary:	Support for Apple Aluminium Keyboards
Product:	xkeyboard-config	Reporter:	Damien Ciabrini <damien.ciabrini>
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Geometries for Apple Aluminium Keyboards Keycodes for Apple Aluminium Keyboards Symbols for Apple Aluminium keyboards Declaration of Apple Aluminium Keyboards Evdev rules for Apple Aluminium Keyboards Compatibility options for Apple Aluminium Keyboards Base rules for Apple Aluminium Keyboards PC compatibility option for Apple Aluminium Keyboards

Description Damien Ciabrini 2010-01-22 16:21:34 UTC

Created attachment 32769 [details] [review]
Geometries for Apple Aluminium Keyboards

Hello,

The following patches aims at providing support for the long, wired version of
Apple Aluminium Keyboards, ANSI, ISO and JIS models.

The support is split in several parts:
  . geometries for all the three models
  . specific symbols found in all three models
  . sets of evdev and base rules
  . XKB options to make the keyboards behave more like PC keyboards

FYI, these patches are an updated version of patches I sent to xorg-devel some weeks ago.

Comment 1 Damien Ciabrini 2010-01-22 16:23:16 UTC

Created attachment 32770 [details] [review]
Keycodes for Apple Aluminium Keyboards

Comment 2 Damien Ciabrini 2010-01-22 16:24:03 UTC

Created attachment 32771 [details] [review]
Symbols for Apple Aluminium keyboards

Comment 3 Damien Ciabrini 2010-01-22 16:24:40 UTC

Created attachment 32772 [details] [review]
Declaration of Apple Aluminium Keyboards

Comment 4 Damien Ciabrini 2010-01-22 16:25:04 UTC

Created attachment 32773 [details] [review]
Evdev rules for Apple Aluminium Keyboards

Comment 5 Damien Ciabrini 2010-01-22 16:25:38 UTC

Created attachment 32774 [details] [review]
Compatibility options for Apple Aluminium Keyboards

Comment 6 Damien Ciabrini 2010-01-22 16:26:04 UTC

Created attachment 32775 [details] [review]
Base rules for Apple Aluminium Keyboards

Comment 7 Sergey V. Udaltsov 2010-01-28 16:22:13 UTC

Some questions:

1. Since most of linux distros are using evdev, why do would we need more mac-specific keycodes (and related mappings)?

2. You've added 2 xkb options. Would it be right to combine them into one?

Comment 8 Damien Ciabrini 2010-02-01 12:47:18 UTC

1. I only provided keycodes in "alukbd" (patch #2) for other like BSDs or Solaris. For those, I needed to define two extra Fkeys F18 and F19. The other two aliases are needed because the geometry files use the evdev name for referencing the eject key (I169) and JIS keypad comma (JPCM).

2. Yes, you're right, since both options are meant to emulate the keys found on regular PC keyboards, it's probably better to merge those two options.

Comment 9 Damien Ciabrini 2010-02-01 14:52:59 UTC

Created attachment 32983 [details] [review]
PC compatibility option for Apple Aluminium Keyboards

As per comment #8

BTW, would you find it more acceptable if I split patch #2 in two for keeping evdev and base keycodes separated?

Comment 10 Sergey V. Udaltsov 2010-03-26 04:43:29 UTC

Ok, I think this is fine. I will commit that.

Comment 11 Sergey V. Udaltsov 2010-03-26 18:36:17 UTC

Everything is committed. Please check in git. Thanks for contribution!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.