Bug 26219

Summary: cope with unavailable directed presences
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: fargoAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: David Laban <david.laban>
Severity: normal    
Priority: high Keywords: patch
Version: git master   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-fargo.git;a=shortlog;h=refs/heads/presence
Whiteboard: milestone4.4 done=1h est=1h
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 26359    

Description Simon McVittie 2010-01-25 09:13:45 UTC
# FIXME: if a client sends a directed unavailable after they make a
        # call, currently we just log out. What we should probably do instead
        # is only listen to presence update/subscribe on the gateway JID and
        # ignore presence to virtual users for logging in/out.
Comment 1 Simon McVittie 2010-01-28 06:23:17 UTC
Relatedly:

2010-01-28 14:21:48+0000 [XmlStream,client] Unhandled error in Deferred:
2010-01-28 14:21:48+0000 [XmlStream,client] Unhandled Error
	Traceback (most recent call last):
	  File "/usr/lib/python2.5/site-packages/twisted/words/xish/utility.py", line 106, in callback
	    methodwrapper(*args, **kwargs)
	  File "/usr/lib/python2.5/site-packages/twisted/words/xish/utility.py", line 27, in __call__
	    self.method(*nargs, **nkwargs)
	  File "/srv/tpfargo/telepathy-fargo/telepathy_fargo/component.py", line 290, in got_presence
	    reply = f(stanza)
	  File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py", line 822, in unwindGenerator
	    return _inlineCallbacks(None, f(*args, **kwargs), Deferred())
	--- <exception caught here> ---
	  File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py", line 737, in _inlineCallbacks
	    result = g.send(result)
	  File "/srv/tpfargo/telepathy-fargo/telepathy_fargo/component.py", line 359, in got_presence_unavailable
	    conn.got_presence_unavailable(stanza)
	exceptions.UnboundLocalError: local variable 'conn' referenced before assignment
Comment 2 Simon McVittie 2010-02-01 06:47:06 UTC
Fixed while trying to fix Bug #26359.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.