Bug 26273

Summary:	Error at compilation time when builddir != srcdir
Product:	shared-mime-info	Reporter:	Florent Viard <florent>
Component:	general	Assignee:	Jonathan Blandford <jrb>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch to fix this error Second patch for this bug.

Description Florent Viard 2010-01-27 07:03:28 UTC

Hi,

Here is a little patch for shared-mime-info to fix an error:
Couldn't find freedesktop.org.xml

at compilation time when builddir != srcdir .

Comment 1 Florent Viard 2010-01-27 07:04:16 UTC

Created attachment 32845 [details] [review]
Patch to fix this error

Comment 2 Bastien Nocera 2010-01-28 08:46:15 UTC

In the future, please provide git formatted patches.

commit b4c2ad132dcde0772c9473efc8cdf2071e2f19e3
Author: Florent Viard <fviard@lacie.com>
Date:   Thu Jan 28 16:45:03 2010 +0000

    Fix error at compilation time when builddir != srcdir
    
    http://bugs.freedesktop.org/show_bug.cgi?id=26273

Comment 3 Florent Viard 2010-02-01 07:40:18 UTC

Hi,

Sorry but this bug wasn't completely solved: if freedesktop.org.xml already exist in srcdir, it is not regenerated in destdir and so xmllint can't find it in destdir.

Here is a second patch (in git diff format ;) ) to solve that. Then this bug will really be fixed!

Comment 4 Florent Viard 2010-02-01 07:42:02 UTC

Created attachment 32971 [details] [review]
Second patch for this bug.

Comment 5 Bastien Nocera 2010-02-01 09:29:11 UTC

(In reply to comment #3)
<snip>
> Here is a second patch (in git diff format ;) ) to solve that. Then this bug
> will really be fixed!

FWIW, that's not a git formatted patch. You need to commit it, and use git-format-patch to get a patch. Your patch is missing authorship and commit log.

commit 08561171f346a1535f224f0ef0c82d9b80e280f8
Author: Florent Viard <fviard@lacie.com>
Date:   Mon Feb 1 17:26:46 2010 +0000

    And another fix when fd.o.xml already exists in srcdir
    
    http://bugs.freedesktop.org/show_bug.cgi?id=26273

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.