Bug 26278

Summary: regression test for calls from XMPP
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: fargoAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: David Laban <david.laban>
Severity: enhancement    
Priority: high Keywords: patch
Version: git master   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-fargo.git;a=shortlog;h=refs/heads/cov
Whiteboard: milestone4.4 done=9h est=9h
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 26097    

Description Simon McVittie 2010-01-27 09:29:10 UTC
There's no regression test for calls from XMPP yet.
Comment 1 Simon McVittie 2010-01-27 11:19:30 UTC
Ready for review but missing some coverage.
Comment 2 Simon McVittie 2010-01-27 11:48:48 UTC
Test merged and is no longer blocking other work, but should still be extended to cover:

* codecs with nonzero number of channels

* codecs with parameters

* needing to ignore video codecs

* should the initiator be the bare or full JID? Currently it's the bare JID and
we assert that

* from-xmpp.py doesn't assert that the candidates have the right ports,

* from-xmpp.py doesn't assert whether the session-accept has any candidates;
should it?

* from-xmpp.py doesn't assert that the PTs in session-accept match the intended

Comment 3 Simon McVittie 2010-01-28 10:30:09 UTC
I'll work on this more tomorrow.
Comment 4 Simon McVittie 2010-01-29 10:28:08 UTC
Improved coverage, coverage stats, misc compliance fixes in <http://git.collabora.co.uk/?p=user/smcv/telepathy-fargo.git;a=shortlog;h=refs/heads/cov>.
Comment 5 Simon McVittie 2010-02-01 04:56:37 UTC
Branch updated; took longer than the 8h estimate due to some bugs + fixes along the way.
Comment 6 Simon McVittie 2010-02-01 08:19:18 UTC
Fixed in git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.