Bug 26313

Summary:	return_from functions should verify that they are called for the right method
Product:	Telepathy	Reporter:	Olivier Crête <olivier.crete>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED WONTFIX	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Olivier Crête 2010-01-28 23:39:44 UTC

I just found a bug where I used the wrong "return_from" generated function. There should be g_return_if_fail() code that makes sure that the right one is called. Otherwise the type safety is useless.

Comment 1 Simon McVittie 2010-01-29 05:27:22 UTC

Can't be fixed, sorry. These functions can't find out which method implementation they're being called from.

(More precisely, fixing this isn't possible within dbus-glib; we'd have to add a parallel API as a layer over dbus-glib.)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.