Bug 26597

Why the empty domain when calling tp_debug_sender_add_message?

Also there are a few style tweaks to fix:

+mcd_debug(const gchar *format,

+void mcd_debug(const gchar *format, ...);

Other than that, looks good to me. Pretty lolz I forgot to do this when writing the initial MC debug patch though! Thanks!

I didn't see domains really in use in MC. I was going to open another bug for that.

Created attachment 33347 [details] [review]
Quick fix

Fixed style.

Created attachment 33348 [details] [review]
Quick fix

Oops! Maybe I should have just made a git branch instead of all this stupid spam.

(In reply to comment #2)
> I didn't see domains really in use in MC. I was going to open another bug for
> that.

I admit that you *can* put "$domain/$category" in that string, as tp-glib and gabble do, but as you said, MC doesn't use debug categories. We can easily ignore this though.

The solution to this is to set G_LOG_DOMAIN to "mcd" in src/Makefile.am, and then use that as the domain, just like all the other Telepathy components do.

As promised, I opened another bug for proper flag/category support, bug 26642. It adds the right domain string to the dbus iface too.

This problem is not blocked on the said bug; we can work without categories pretty easily.

Created attachment 33406 [details] [review]
Use telepathy debug interface

I notice your branch related to this removes an extern function. Please don't do that (it would break osso-mission-control on Maemo unless this function is unused, and I happen to know that mcd_debug_set_level() is called by osso-mission-control).

(In reply to comment #8)
> Created an attachment (id=33406) [details]
> Use telepathy debug interface

Yeah, this looks alright if it works; I've not actually tested it.

Get mergin'!

Jonny,

Could you commit this? I don't have write access to tp git stuff yet.

Just 'git apply' the above and sign it off.

Thanks!