Bug 26637

Summary:	review needed for empathy-logstore
Product:	Telepathy	Reporter:	Cosimo Alfarano <cosimo.alfarano>
Component:	logger	Assignee:	Danielle Madeley <danielle>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/kalfa/telepathy-logger.git;a=shortlog;h=refs/heads/empathy-logstore
Whiteboard:
i915 platform:		i915 features:

Description Cosimo Alfarano 2010-02-18 12:14:08 UTC

http://git.collabora.co.uk/?p=user/kalfa/telepathy-logger.git;a=shortlog;h=refs/heads/empathy-logstore

thanks

Comment 1 Danielle Madeley 2010-02-18 19:02:05 UTC

It would be nice to combine this with the patch in #26621.

+  /* TODO add destructor */

Do this?

Comment 2 Danielle Madeley 2010-02-21 17:40:43 UTC

Also, I've stared at this a little bit closer.

log_manager_constructor() line 130ish. What is all of this doing in constructor(), instead of in init() or constructed()?

I think it should be moved to init() or constructed() and constructor() should only contain the singleton setup.

Comment 3 Cosimo Alfarano 2010-02-22 04:15:29 UTC

Moved to _init

Comment 4 Cosimo Alfarano 2010-02-22 06:24:28 UTC

rebased merged to master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.