Bug 26648

Summary:	TplLogStoreEmpathy should not get valid accounts from the AM
Product:	Telepathy	Reporter:	Cosimo Alfarano <cosimo.alfarano>
Component:	logger	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	nicolas, pochu27
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/kalfa/telepathy-logger.git;a=shortlog;h=refs/heads/log-store-AM
Whiteboard:
i915 platform:		i915 features:

Description Cosimo Alfarano 2010-02-19 06:30:20 UTC

Currently in log_store_empathy_search_hit_new() log-store-empathy get a list of valid accounts from the AM, because of the way Empathy handled it.

In TPL it shoudln't be used only valid accounts, or the search will cut off all the accounts that for example were removed but still in the TPL log history.

Probably calling tp_account_manager_get_valid_accounts() is useles and since it needs preparation, it is actually not needed.
Instead a query to retrieve all the current logged account would be its replacement.
From TPL LogStore's point of view, it doesn't matter if an account is valid or not, just if it has some LogEntry to show or not.

Comment 1 Cosimo Alfarano 2010-04-05 11:19:12 UTC

A branch fixing it, removing AccountManager references from TplLogStoreXML (former TplLogStoreEmpathy) is at
http://git.collabora.co.uk/?p=user/kalfa/telepathy-logger.git;a=shortlog;h=refs/heads/log-store-AM

This branch uses a patch (tpl_get_tp_account()) which has been introduces by another branch (danni's) still to be reviewed

(not yet to review)

Comment 2 Nicolas Dufresne 2011-01-13 14:16:08 UTC

(In reply to comment #1)
> A branch fixing it, removing AccountManager references from TplLogStoreXML
> (former TplLogStoreEmpathy) is at
> http://git.collabora.co.uk/?p=user/kalfa/telepathy-logger.git;a=shortlog;h=refs/heads/log-store-AM
> 
> This branch uses a patch (tpl_get_tp_account()) which has been introduces by
> another branch (danni's) still to be reviewed

Reference ?

Comment 3 Emilio Pozuelo Monfort 2011-06-22 09:04:51 UTC

This blocks Empathy showing logs for removed accounts: https://bugzilla.gnome.org/show_bug.cgi?id=610455

Comment 4 GitLab Migration User 2019-12-03 19:25:25 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-logger/issues/2.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.