Summary: | "fc-match sans file" doesn't work | ||
---|---|---|---|
Product: | fontconfig | Reporter: | Behdad Esfahbod <freedesktop> |
Component: | fc-match | Assignee: | Keith Packard <keithp> |
Status: | RESOLVED FIXED | QA Contact: | Behdad Esfahbod <freedesktop> |
Severity: | normal | ||
Priority: | medium | CC: | akira, freedesktop, mpsuzuki |
Version: | 2.7 | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Behdad Esfahbod
2010-02-23 13:26:59 UTC
That looks like because FcNameUnparse() ignores FC_FILE only. what's wrong with simply getting rid of "!strcmp (o->object, FC_FILE)" from the expression? Using FcPatternFormat() may be an idea. but the issue would be how to get the better "format" string against the FcObjectSet. Once getting rid of the above code, the result looks like: % ./fc-match/fc-match sans file :file=/usr/share/fonts/dejavu/DejaVuSans.ttf proposed one line patch: http://cgit.freedesktop.org/~tagoh/fontconfig/commit/?h=bz26718&id=29c6bd85a7e08b7686a95b4da5e373e973ac54e1 That's not enough. I guess your change breaks fc-list. I'll fix by switching fc-list et al. to using FcPatternFormat() I guess. commit e0be405a1dd5765e36152c754a47c8ad7ff0ab85 Author: Behdad Esfahbod <behdad@behdad.org> Date: Mon Jun 20 11:22:17 2011 -0400 Bug 26718 - "fc-match sans file" doesn't work - Do not throw away FC_FILE in FcNameUnparse - Update the builtin "fclist" format to remove FC_FILE properly instead - Switch fc-list to use FcPatternFormat() Note that I had previously broken fc-list and it was not showing the file name anymore. No one noticed that it seems! Now fixed. Aha, thanks. works fine for me. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.