Bug 26877

Summary:	review: Observer properties leak and type fixs
Product:	Telepathy	Reporter:	Danielle Madeley <danielle>
Component:	logger	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	cosimo.alfarano, sjoerd, travis.reitter
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/danni/telepathy-logger.git;a=commitdiff;h=05eac85e49278f1c29bbebe20a913ca344278a8a
Whiteboard:
i915 platform:		i915 features:

Description Danielle Madeley 2010-03-03 20:23:31 UTC

This cleans up some leaks and one misnamed type in the Observer GObject properties.

http://git.collabora.co.uk/?p=user/danni/telepathy-logger.git;a=commitdiff;h=05eac85e49278f1c29bbebe20a913ca344278a8a


Was also wondering, why is the registered-channels property a D-Bus style property when it's not exported over D-Bus?

Comment 1 Travis Reitter 2010-03-03 21:53:27 UTC

(In reply to comment #0)
> This cleans up some leaks and one misnamed type in the Observer GObject
> properties.
> 
> http://git.collabora.co.uk/?p=user/danni/telepathy-logger.git;a=commitdiff;h=05eac85e49278f1c29bbebe20a913ca344278a8a

This patch looks fine to me.

> Was also wondering, why is the registered-channels property a D-Bus style
> property when it's not exported over D-Bus?

It looks like it's exported as a D-Bus property:

401   /* properties on the Client.Observer interface */
402   static TpDBusPropertiesMixinPropImpl client_observer_props[] = {
403     {"ObserverChannelFilter", "channel-filter", NULL},
404     {NULL}
405   };

Comment 2 Danielle Madeley 2010-03-03 21:57:14 UTC

registered-channels, not channel-filter.

Comment 3 Danielle Madeley 2010-03-03 21:58:19 UTC

Merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.