Bug 26901

Summary: [bisected] some piglit and glean cases regressed
Product: Mesa Reporter: zhao jian <jian.j.zhao>
Component: Drivers/DRI/i965Assignee: Eric Anholt <eric>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: high    
Version: unspecified   
Hardware: Other   
OS: Linux (All)   
i915 platform: i915 features:
Attachments: xorg.0.log

Description zhao jian 2010-03-05 01:17:50 UTC
Created attachment 33783 [details]

System Environment:
Libdrm:         (master)b5495527f4c7087d430c0d1c2b83357c40b9c16c
Mesa:           (master)c7f7a309af54c76eccb451aa0c4f007656ebe7e1
Xserver:                (master)bbae92795c7eab062e6722c42fa7915e0cee5d69
Xf86_video_intel:       (master)a0ee9c3d9c72962c8d513ec8c43dd4a21e316947
Kernel: (drm-intel-next)6070a4a928f8c92b9fae7d6717ebbb05f425d6b2

Bug detailed description:
Three piglit cases(Texturing/depth-tex-modes,Texturing/depth-tex-modes-glsl, Texturing/texdepth) and one glean case(depthStencil) was failed with the error info: intel_regions.c:195: intel_region_alloc: Assertion `aligned_pitch == pitch * cpp\' failed.  It works well on 945GM. It was caused by 
commit 179d2c0e0bcf96fc40107882ccab909af8c89853
Author: Eric Anholt <eric@anholt.net>
Date:   Tue Mar 2 15:34:17 2010 -0800

    intel: Use drm_intel_bo_alloc_tiled for region allocs.

    This moves the logic for how to align pitches, heights, and sizes of
    objects to one central location.  Fixes rendering with texture tiling
    on i915.  Note that current libdrm is required for the change for
    I915_TILING_NONE pitch alignment.

Reproduce step:
1. xinit
2. ./depth-tex-modes -auto
Comment 1 Eric Anholt 2010-03-07 14:09:25 UTC
commit 1d4d1e6b138aac8bd734c4c20617a43fb3337c63
Author: Eric Anholt <eric@anholt.net>
Date:   Thu Mar 4 16:09:40 2010 -0800

    intel: Only align Y-tiling pitch to the Y tile width.
    Fixes piglit depth-tex-modes on gen4.
Comment 2 Gordon Jin 2010-03-07 21:27:17 UTC
It should be noted the fix is in libdrm, and post 2.4.19.
Comment 3 zhao jian 2010-03-07 22:24:12 UTC
It works well now with the newest commit. 
Libdrm:         (master)04fd3872ee8bd8d5e2c27740508c67c2d51dbc11
Mesa:           (master)9860f652e271d03672ec3e5f0e379170953a1e56
Xserver:                (master)bbae92795c7eab062e6722c42fa7915e0cee5d69
Xf86_video_intel:       (master)8ece6cf5afa1bb0d8d9328696422f42f3c3adbd6

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.