Bug 26951

Summary: Expose “MUC full” as Busy on the group interface.
Product: Telepathy Reporter: Will Thompson <will>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: 0.8   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=commitdiff;h=refs/heads/busy-kind-of-means-full
Whiteboard: review+
i915 platform: i915 features:

Description Will Thompson 2010-03-08 03:13:16 UTC 
When you try to join a room uninvited, and it's full, the request correctly fails with the Channel.Full error.

However, if you're invited to a room, and you try to accept the invitation and the room's full, you get removed from the group interface for reason None and then the channel spontaneously closes. In TpChannel terms, the invalidation error is TP_ERROR_REMOVED_FROM_GROUP, TP_CHANNEL_GROUP_CHANGE_REASON_NONE, which is unhelpful.

My patch in busy-kind-of-means-full exposes this as Group_Change_Reason_Busy, which seems like a reasonable approximation. A better fix might be:

• Make Gabble include the Channel.Full error (and indeed other errors like
Invite_Only) in the MembersChangedDetailed details;
• Make TpChannel smarter about what it saves from the MembersChanged[Detailed]
signal so that it can synthesise better error messages.

But using a slightly more useful group change reason doesn't hurt anyway.
Comment 1 Simon McVittie 2010-03-09 07:02:17 UTC 
(In reply to comment #0)
> My patch in busy-kind-of-means-full exposes this as Group_Change_Reason_Busy,
> which seems like a reasonable approximation.

That looks OK to merge.

> A better fix might be:
> 
> • Make Gabble include the Channel.Full error (and indeed other errors like
> Invite_Only) in the MembersChangedDetailed details;
> • Make TpChannel smarter about what it saves from the
> MembersChanged[Detailed]
> signal so that it can synthesise better error messages.

This is part of Bug #23369, for which I have a rather bit-rotted branch.
Comment 2 Will Thompson 2010-03-26 03:37:52 UTC 
(In reply to comment #1)
> (In reply to comment #0)
> > My patch in busy-kind-of-means-full exposes this as Group_Change_Reason_Busy,
> > which seems like a reasonable approximation.
> 
> That looks OK to merge.

Merged to 0.8 as http://git.collabora.co.uk/?p=telepathy-gabble.git;a=commit;h=bde36dba and master as http://git.collabora.co.uk/?p=telepathy-gabble.git;a=commit;h=7ee0588206

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.