Bug 27129

Summary: test/twisted/README is outdated
Product: Telepathy Reporter: Tomeu Vizoso <tomeu>
Component: mission-controlAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: git master   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/tomeu/telepathy-mission-control.git;a=shortlog;h=refs/heads/bug-27129
Whiteboard: review-
i915 platform: i915 features:

Description Tomeu Vizoso 2010-03-17 05:58:37 UTC
instructions for running an individual test are wrong, the env var is TWISTED_BASIC_TESTS
Comment 1 Simon McVittie 2010-04-12 09:51:20 UTC
The patch + revert shouldn't exist in history (just get rid of both and leave only the corrected patch).

> +  make -C test/twisted check-twisted \
> +        TWISTED_BASIC_TESTS= \
> +        TWISTED_SEPARATE_TESTS=dispatcher/create-at-startup.py

I'd be inclined to only mention this version, and not the other one - if you're only running one test (or a few tests) it doesn't matter whether you have a separate instance of MC for each or not.

In principle, all tests should be separate, but that is (or was?) far too slow when valgrinding (which adds a 5-second delay at the end of each MC run to wait for things to settle down), so I only ran tests separately-by-default if they really needed to be.
Comment 2 Simon McVittie 2010-05-28 03:06:16 UTC
Fixed in 5.5.0, WONTFIX for 5.4.x

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.