Bug 27166

Summary:	Gabble MailNotification: Unread count is maxed to 30
Product:	Telepathy	Reporter:	Nicolas Dufresne <nicolas>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	All
OS:	All
URL:	http://git.collabora.co.uk/?p=user/nicolas/telepathy-gabble.git;a=commit;h=e817d77310d94c5e1aec42a848eacededd82f01c
Whiteboard:
i915 platform:		i915 features:

Description Nicolas Dufresne 2010-03-18 08:12:02 UTC

It seems that the unread count never go higher then 30. This is due to the count being based on the number of mail description received. To reduce network, GMail server limits this number to 30. But the real number can be retrieved from the total-matched attribute of mailbox XML node.

This patch fixes the problem:

http://git.collabora.co.uk/?p=user/nicolas/telepathy-gabble.git;a=blobdiff;f=src/conn-mail-notif.c;h=8ba031873c7507506578bf5939a21c777b88570a;hp=072c693debc0c04d9a1898fe20f229948c8105d3;hb=e817d77310d94c5e1aec42a848eacededd82f01c;hpb=1af8f89cc4833a0c553f693a2dd691ffccc7f694

Comment 1 Simon McVittie 2010-03-18 09:12:05 UTC

Please always make changes on a branch, not on master, unless they are *incredibly* trivial (i.e. updating NEWS).

The implementation of this change looks good, but please also propose a spec patch to make it clear that UnreadMails might not be complete, and UnreadMailCount might be more than len(UnreadMails).

Comment 2 Simon McVittie 2010-03-26 06:49:13 UTC

It seems this was merged, but Nicolas forgot to close it. Will be in 0.9.9.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.