| Summary: | Incorrect '-zoom' handling in pdftohtml | ||
|---|---|---|---|
| Product: | poppler | Reporter: | Pavel Denisov <pavel.a.denisov> |
| Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | jwilk, pasky, pavel.a.denisov |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Patch
PDF that can be used for testing |
||
|
Description
Pavel Denisov
2010-03-24 07:39:48 UTC
Created attachment 34408 [details]
PDF that can be used for testing
Comment on attachment 34408 [details]
PDF that can be used for testing
pdftohtml -nomerge -noframes -c test.pdf
Command to test: pdftohtml -nomerge -noframes -c test.pdf Sorry we can not accept the patch, while it is true that it fixes this very particular file, it causes a regression when running "pdftohtml 2006rawsurveyreport.pdf" changing We would also like to thank the 400+ members of the <a href="http://openraw.org/lists/">OpenRAW mailing list</a> to <a href="http://openraw.org/lists/">We would also like to thank the 400+ members of the OpenRAW mailing list</a> We'd be more than happy that accept the patch if it didn't cause regressions. http://www.openraw.org/files/2006rawsurveyreport.pdf The bug doesn't exist in 0.15.3 anymore. I still need the patch for poppler-0.15.3 for -zoom to work at all. However, only the first hunk is required; the second affects only dpi of the pdf, which should be mostly irrelevant. Albert: This regression happens *only* because -zoom actually starts to work with this patch, and its default value is not 1, but 1.5. Therefore, with this patch, all PDFs are suddenly zoomed to 1.5x and it appears there is an orthogonal bug somewhere in the link detection (with -zoom 2, the link is correct again). I think: * such a small regression seems incomparable with actually working -zoom option, which can produce so much better PDFs to read, especially on larger resolutions * if you still care, simply change scale default value from 1 to 1.5. This will mean that by default, the output shall be pretty much identical as in previous versions, but users will actually be able to change the zoom settings if they want. This patch has been commited meanwhile due to some other reason and well, zooming to 1.5 was the default in the --help and in the man page so i think it's time we honour it :D So yeah it will change the output from 0.14 to 0.16 but it will do what it was supposed to do do i think i'll leave it that way. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.