| Summary: | mesa deadlocks with latest HoN game | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Török Edwin <edwin+bugs> |
| Component: | Mesa core | Assignee: | Default DRI bug account <dri-devel> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | brianp |
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | tentative patch | ||
|
Description
Török Edwin
2010-03-27 03:28:58 UTC
Looks like it is trying to lock a mutex that is already locked:
_mesa_HashFindFreeKeyBlock(
line 438: _glthread_LOCK_MUTEX(table->Mutex);
line 450: if (_mesa_HashLookup(table, key)) {
_mesa_HashLookup(
line 140: _glthread_LOCK_MUTEX(table->Mutex);
Looks like this is caused by this commit: commit 107a2ec9eef53dee038c1bcc0d956c5667e0b68f Author: Brian Paul <brianp@vmware.com> Date: Tue Feb 16 08:21:38 2010 -0700 Created attachment 34502 [details] [review] tentative patch The patch I just attached fixes the deadlock, please apply. Patch to src/mesa/main/hash.c: https://bugs.freedesktop.org/attachment.cgi?id=34502 The patch looks good (except for "inline" should be "INLINE"). I verified the patch here by forcing the code path in question with a couple Mesa demos. I'll commit shortly. Either the game uses a _lot_ of textures or it uses its own (very large) texture IDs at some point. Evidently, the slow path in _mesa_HashFindFreeKeyBlock() hasn't been hit before! Please retest with latest Mesa sources from git and then close the bug. Thanks. (In reply to comment #6) > The patch looks good (except for "inline" should be "INLINE"). I verified the > patch here by forcing the code path in question with a couple Mesa demos. I'll > commit shortly. > > Either the game uses a _lot_ of textures or it uses its own (very large) > texture IDs at some point. Evidently, the slow path in > _mesa_HashFindFreeKeyBlock() hasn't been hit before! > > Please retest with latest Mesa sources from git and then close the bug. > Thanks. > Thanks. I see you merged my commit to the 7.8 branch, but not to master (I use master). i've been working on this all day; im unfamiliar with linux and it took me awhile too google up how to patch and everything; so i could've done something wrong. but i followed the directions here > https://wiki.ubuntu.com/XorgOnTheEdge for building your own drivers. downloaded the mesa 7.9 git karmic; applied patch, installed mesa-utils and mesa-common, rebooted; game still froze on me. (In reply to comment #8) > i've been working on this all day; im unfamiliar with linux and it took me > awhile too google up how to patch and everything; so i could've done something > wrong. but i followed the directions here > > https://wiki.ubuntu.com/XorgOnTheEdge for building your own drivers. downloaded > the mesa 7.9 git karmic; applied patch, installed mesa-utils and mesa-common, > rebooted; game still froze on me. > like i said, im a big newbie. i thought those were the only 2 debs, now looking in the directory; well, lets just say ill tell you if it works or not in 20-30 minutes. :D HoN works according to a lot of feedback from users lately. The patch was pushed per Brian's comment, and the fixes from 7.8 have been merged to master. Closing. Feel free to reopen if you still encounter any issues. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.