Bug 27379

Summary:	Add a new signal, allKnownContactsChanged
Product:	Telepathy	Reporter:	Dario Freddi <drf54321>
Component:	tp-qt	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch as described Patch, take 2 Patch, take 3 (docs included) Patch, take 4 (docs and unit test update included)

Description Dario Freddi 2010-03-30 13:42:54 UTC

Created attachment 34549 [details] [review]
Patch as described

The attached patch adds a new signal, allKnownContactsChanged, which would be useful to monitor contact addition/removal in a third party application, as discussed on IRC with Olli.

I still have not added any API docs since I want to be sure that the patch is OK. Once it is, I'll send an additional one on the top of this one with documentation.

It appears to work: the signal is correctly emitted upon contact addition/removal.

This patch is severely needed for Telepathy/KDE.

Comment 1 Dario Freddi 2010-03-30 14:25:11 UTC

Created attachment 34550 [details] [review]
Patch, take 2

Updating the patch

Comment 2 Dario Freddi 2010-03-30 15:10:46 UTC

Created attachment 34560 [details] [review]
Patch, take 3 (docs included)

Updated as requested

Comment 3 Dario Freddi 2010-03-31 14:15:14 UTC

Created attachment 34589 [details] [review]
Patch, take 4 (docs and unit test update included)

Fixed upon Olli's suggestions. Also added a small unit test to conn-roster.cpp, which of course passes :)

Comment 4 Andre Moreira Magalhaes 2010-04-01 08:27:00 UTC

Applied upstream. It will be in next release 0.3.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.