| Summary: | Bad usage of _add_immutables in ChannelTypeRoomList | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Krzysztof Klinikowski <kkszysiu> |
| Component: | tp-python | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
patch
git-format patch |
||
(In reply to comment #0) > so I attached a small patch to fix it. I think you forgot to attach the patch! Created attachment 34623 [details] [review] patch Youre right. I forgot about that :D Good catch and the patch is good. Could you provide a git format-patch patch please? It'll make it easier to retain your ownership of the work. Created attachment 34646 [details] [review] git-format patch Done but you should change name of that patch I think (my English is too bad to write commit messages) :D Thanks, merged. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Another little bug in ChannelTypeRoomList class. For now calling of _add_immutables in that class looks like self._add_immutables(self, {'Server': CHANNEL_TYPE_ROOM_LIST}) but function _add_immutables needs just self and props so I attached a small patch to fix it.