Bug 27415

Summary: Bad usage of _add_immutables in ChannelTypeRoomList
Product: Telepathy Reporter: Krzysztof Klinikowski <kkszysiu>
Component: tp-pythonAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: patch
git-format patch

Description Krzysztof Klinikowski 2010-04-01 11:40:54 UTC
Another little bug in ChannelTypeRoomList class. For now calling of _add_immutables in that class looks like self._add_immutables(self, {'Server': CHANNEL_TYPE_ROOM_LIST}) but function _add_immutables needs just self and props so I attached a small patch to fix it.
Comment 1 Jonny Lamb 2010-04-02 09:10:57 UTC
(In reply to comment #0)
> so I attached a small patch to fix it.

I think you forgot to attach the patch!
Comment 2 Krzysztof Klinikowski 2010-04-02 11:35:20 UTC
Created attachment 34623 [details] [review]
patch
Comment 3 Krzysztof Klinikowski 2010-04-02 11:35:45 UTC
Youre right. I forgot about that :D
Comment 4 Jonny Lamb 2010-04-03 05:22:04 UTC
Good catch and the patch is good.

Could you provide a git format-patch patch please? It'll make it easier to retain your ownership of the work.
Comment 5 Krzysztof Klinikowski 2010-04-03 05:44:38 UTC
Created attachment 34646 [details] [review]
git-format patch
Comment 6 Krzysztof Klinikowski 2010-04-03 05:45:48 UTC
Done but you should change name of that patch I think (my English is too bad to write commit messages) :D
Comment 7 Jonny Lamb 2010-04-03 05:57:44 UTC
Thanks, merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.