Bug 27463

> TplChannelText: show debug message only on non-empthy lists

Every Empathy developer's favourite typo. You mean empty :-)

> +  g_return_val_if_fail (!TPL_STR_EMPTY (chat_id), FALSE);

Not an objection, but if you depend on telepathy-glib (>= 0.11.0) you can use the macro tp_str_empty() :-)

> +        "Unable to acknowledge pending message %d for chanenl %s: not found",

That's not how you spell channel.


>          }
> +      else
> +        PATH_DEBUG (proxy, "msg_id %d acknowledged", msg_id);

Consistent brace usage, please (the "if" clause has {}, so the "else" needs them too)

Otherwise looks good.

>> TplChannelText: show debug message only on non-empthy lists
>Every Empathy developer's favourite typo. You mean empty :-)

fixed :)

>> +        "Unable to acknowledge pending message %d for chanenl %s: not found",
>That's not how you spell channel.

fixed.


> Consistent brace usage, please (the "if" clause has {}, so the "else" needs
them too)

fixed.


> Not an objection, but if you depend on telepathy-glib (>= 0.11.0) you can use
the macro tp_str_empty() :-)

Yep, I saw the change, I'll update it using tp_str_empty in another path.

There are lots of pending branches around which need to be merged, after it I'll start a cycle of general clean up of such things, before we'll declare the stable API.

Ship it