Bug 27535

Summary:	GetContactAttributes() no longer specified to be needlessly fascist about interfaces
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	sunshine	Assignee:	Krzysztof Klinikowski <kkszysiu>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2010-04-08 05:59:10 UTC

telepathy-sunshine probably needs the same change as telepathy-butterfly, since GetContactAttributes apparently isn't provided by telepathy-python. See the bugs referenced below.

Will wrote the following patch for Butterfly:

http://git.collabora.co.uk/?p=telepathy-butterfly.git;a=commitdiff;h=07bd347f89195f357f69622b8d02239f663a1a3d

+++ This bug was initially created as a clone of Bug #27374 +++

+++ This bug was initially created as a clone of Bug #27325 +++

From the definition of GetContactAttributes():

> It is an error to request interfaces that are not supported by this
> Connection (i.e. mentioned in the ContactAttributeInterfaces
> property).
>
> | This makes it possible to distinguish between interfaces for which
> | the Connection has nothing to say (e.g. we don't know the avatar
> | tokens of any of the contacts, so we omitted them all), and interfaces
> | for which this API isn't supported.

This is needlessly pedantic. If we had instead said that the CM must
ignore interfaces which aren't supported on the Contacts interface, then
client code that does care could still check ContactAttributeInterfaces
to distinguish those two cases, and client code that doesn't care
wouldn't have to mess around checking the list of interfaces it passes
to GetContactAttributes().

Comment 1 Krzysztof Klinikowski 2010-04-08 10:44:19 UTC

Thanks. I'll fixed that I think and will merge it soon :)

Comment 2 Krzysztof Klinikowski 2011-05-07 10:38:57 UTC

Closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.