Bug 27540

After a series of XVMC changes made in the intel driver git, the driver no longer starts on my Intel 965GM (Thinkpad R61) due to the following assertion:

X: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char *)
&((av)->bins[((1) - 1) * 2])) - __builtin_offsetof (struct malloc_chunk, fd))))
&& old_size == 0) || ((unsigned long) (old_size) >= (unsigned
long)((((__builtin_offsetof (struct malloc_chunk, fd_nextsize))+((2 *
(sizeof(size_t))) - 1)) & ~((2 * (sizeof(size_t))) - 1))) && ((old_top)->size &
0x1) && ((unsigned long)old_end & pagemask) == 0)' failed.
Aborted

Right after this is printed to the X log:
[   729.905] (==) intel(0): DPMS enabled
[   729.905] (==) intel(0): Intel XvMC decoder enabled
[   729.905] (II) intel(0): Set up textured video
[   729.905] (II) intel(0): Set up overlay video

I've bisected this, and it resulted in the following commit as the first bad commit: (all previous commits start fine)
79fe4caafd21f6ca262901eac4a66ce5a4eaf548 is the first bad commit
commit 79fe4caafd21f6ca262901eac4a66ce5a4eaf548
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Mar 9 16:20:33 2010 +0100

    XvMC: dynamically allocate adaptor
    
    And kill all the static structures. This way it's clearer what's
    common and what's specific. And the code is shorter too.
    
    Also clean up src/i830_hwmc.c - kill the nonstandard surface types
    for i915 and the associated code.
    
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Bisect log:
git bisect start
# bad: [bdf0ee509c26ab35e60f3ed02549efa435be032f] i965 Xv: fix chroma pitch
git bisect bad bdf0ee509c26ab35e60f3ed02549efa435be032f
# good: [440b4d207b730112169827d0b90b46596659b504] Increase version to 2.11.0
git bisect good 440b4d207b730112169827d0b90b46596659b504
# good: [00b63ecb192b7eafea9482bf5c5c5d442ce2c6fc] XvMC: directly set driver type in context creation
git bisect good 00b63ecb192b7eafea9482bf5c5c5d442ce2c6fc
# bad: [6c44ce9e127e531224bac825da7918800a3e6a1a] libXvMC i915: s/i915XvMCSurface/struct intel_xvmc_surface/
git bisect bad 6c44ce9e127e531224bac825da7918800a3e6a1a
# bad: [9eeabf876d1f70f5525bbac438414557dd2d4335] libXvMC: derive driver surfaces from struct intel_xvmc_surface
git bisect bad 9eeabf876d1f70f5525bbac438414557dd2d4335
# bad: [a0058369bbdfb49f8df5ee1e50671115927d3565] XvMC: kill intel_xvmc_command
git bisect bad a0058369bbdfb49f8df5ee1e50671115927d3565
# bad: [79fe4caafd21f6ca262901eac4a66ce5a4eaf548] XvMC: dynamically allocate adaptor
git bisect bad 79fe4caafd21f6ca262901eac4a66ce5a4eaf548