Bug 27550

Summary:	KeyError in P2PSessionManager. _on_blob_received()
Product:	papyon	Reporter:	Markus Korn <thekorn>
Component:	general	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	NEW ---	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	84yelo3
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Markus Korn 2010-04-09 04:34:23 UTC

This issue has originally been reported by Marcelo Messias and others at Launchpad: https://launchpad.net/bugs/450951

The reported Tracebacks are looking like:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/papyon/msnp2p/session_manager.py", line 53, in <lambda>
    lambda tr, blob: self._on_blob_received(blob))
  File "/usr/lib/pymodules/python2.6/papyon/msnp2p/session_manager.py", line 164, in _on_blob_received
    session = self._sessions[session_id]
  File "/usr/lib/python2.6/weakref.py", line 54, in __getitem__
    o = self.data[key]()
KeyError: 1098564

The version of papyon used is 0.4.5


I had I quick look at the code, line 164 of session_manger.py makes no sense to me. If session is None, it is None because ._get_session() returned None, and this is because session_id was not found in the ._sessions dict.
What about replacing this line with "return None"?

Thanks,
Markus

Comment 1 Jonny Lamb 2010-04-09 08:55:17 UTC

*** Bug 24154 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.