| Summary: | TpAccount doesn't always notify::connection | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-glib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | guillaume.desmottes, vinaysubscribe |
| Version: | 0.10 | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/010-account-notify | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
This branch might fix this, but is, so far, untested: http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/010-account-notify I've updated the branch to include a regression test, and a fix for an unrelated TpAccount bug (it leaks the GHashTable containing parameters). Review would be appreciated; we can hopefully get this fixed in 0.10.5 and 0.11.4. Looks good. Fixed in git telepathy-glib-0.10 and master; will be in 0.10.5 and 0.11.4, respectively. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
TpAccount doesn't automatically create a new TpConnection when the connection_object_path member changes, only when someone actually asks for it. This has the surprising side-effect that notify::connection isn't emitted when the object path is first discovered. This block in _tp_account_update: > if (g_hash_table_lookup (properties, "Connection") != NULL) should emit notify::connection; if someone actually cares about it, they'll call tp_account_get_connection (directly or via the property getter), resulting in the creation of a TpConnection.