Bug 27789

Summary:	Interfaces should use dbus Get to retrieve properties, only falling back to querying for them if necessary
Product:	Telepathy	Reporter:	Morten Mjelva <morten.mjelva>
Component:	tp-python	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch patch patch

Description Morten Mjelva 2010-04-22 03:24:04 UTC

Created attachment 35233 [details] [review]
patch

Changed interfaces in telepathy.client to first check properties with Get(), and then fall back to using the associated method calls to retrieve properties only if necessary. Also did some other minor cleanups.

Comment 1 Simon McVittie 2010-04-22 03:36:47 UTC

There's no benefit in using Get() rather than GetInterfaces() - it's the same number of D-Bus messages, with a more complex structure.

However, using GetAll() to get several properties at once (like telepathy-glib does for most properties) would be beneficial.

Comment 2 Morten Mjelva 2010-04-22 03:37:15 UTC

Created attachment 35234 [details] [review]
patch

Comment 3 Morten Mjelva 2010-04-22 04:36:54 UTC

Created attachment 35235 [details] [review]
patch

Changed patch to use GetAll

Comment 4 Morten Mjelva 2010-04-22 09:33:20 UTC

my last patch is screwed up. i'll add a new one when i've fixed it

Comment 5 GitLab Migration User 2019-12-03 20:14:36 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-python/issues/15.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.