Bug 27790

One thing this branch doesn't do is replace our whitespace keepalive pings (which are sent less frequently than the GTalk server's pings) with the <flush/> command. I'm not sure whether that's a good idea, in any case. The radio's waking up every few minutes for the keepalives, so on the one hand we may as well; on the other hand, eds-backend-telepathy on Maemo 5 listens to this same MCE signal and doesn't push presence updates to the UI when the device is idle, so they'd be ignored anyway.

> +gabble_slacker_dispose (GObject *object)

Should chain up to the parent's dispose

> +gabble_slacker_finalize (GObject *object)

Should chain up to the parent's finalize, or just not exist

Otherwise, looks good to me.

(In reply to comment #2)
> > +gabble_slacker_dispose (GObject *object)
> 
> Should chain up to the parent's dispose

Done.
> 
> > +gabble_slacker_finalize (GObject *object)
> 
> Should chain up to the parent's finalize, or just not exist

Deleted.

review+, ship it.

One minor comment:

+  ((GObjectClass *) gabble_slacker_parent_class)->dispose (object);

This assumes that the parent class *has* a dispose(). For dispose() that's OK, because its parent is GObject, which has an API guarantee that it will do certain things (e.g. kill off weak refs) when disposed, hence it must continue to have a dispose() forever; but it's not OK for (say) constructed(), so I've been using a "check before chaining up" pattern consistently for all similar functions.

(For instance, see
<http://git.collabora.co.uk/?p=telepathy-glib.git;a=commitdiff;h=9cc5f93f913896c7053c78b09d1f745cfebd58cd>.)

(In reply to comment #4)
> review+, ship it.

Shipped to 0.8.

> One minor comment:
> 
> +  ((GObjectClass *) gabble_slacker_parent_class)->dispose (object);
> 
> This assumes that the parent class *has* a dispose().

Yes, I know.