Bug 27806

Summary:	result leak in tp_account_set_enabled_async
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	tp-glib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/account-27806
Whiteboard:	r+
i915 platform:		i915 features:

Description Guillaume Desmottes 2010-04-23 00:29:31 UTC

I didn't check carrefully but reading the code it seems that tp_account_set_enabled_async leaks the GSimpleAsyncResult. It should be unrefed after g_simple_async_result_complete_in_idle.
We should probably audit the code as that's a common pattern.

Comment 1 Simon McVittie 2010-04-26 05:09:18 UTC

Shouldn't be too difficult for a new contributor who's familiar with GObject idioms?

Comment 2 Simon McVittie 2010-09-10 06:31:32 UTC

This bug is sufficiently low-hanging that we should fix it before 0.12, so I've claimed it.

Comment 3 Guillaume Desmottes 2010-09-13 04:55:42 UTC

++

Comment 4 Simon McVittie 2010-09-13 05:24:00 UTC

Fixed in git for 0.11.15, which is imminent

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.