| Summary: | TpChannelManager should leave TargetID in the request dict (or even add it if missing?) | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/jonny/telepathy-glib.git;a=shortlog;h=refs/heads/target-id-in-channel-manager | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
I spoke to Will about this bug. We decided that the flag can be added later if it's really necessary. Here's a branch to fix this bug. I added a test and loads of annoying test framework to make it testable. Hope you like boilerplate! I rebased this onto master, and fixed all my review comments: http://cgit.collabora.com/git/user/wjt/telepathy-glib.git/log/?h=target-id-in-channel-manager Take a look! Implementation looks correct, but didn't follow the conversation for the idea. So if that's the way to go, then +1 Thanks for the review! Merged to master for 0.15.5. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
11:55 < wjt> i made TpChannelManager normalize from id to handle ... 12:03 < smcv> wjt: didn't we decide that for requesting phone numbers with trailing DTMF, TpChannelManager should pass the un-normalized ID through as well? ... 12:04 < Robot101> generally we should propogate unmolested ids as much as possible 12:04 < smcv> right 12:04 < smcv> currently we guarantee to remove the ID from the dict entirely 12:04 < smcv> so passing it through after all shouldn't break anyone This would also be useful to fix Gabble Bug #22456 and Bug #25143, but is not sufficient: 12:06 < wjt> smcv: right, but that's not the problem 12:06 < wjt> smcv: the handle normalization function thorws an erorr 12:06 < wjt> because "foo" isn't a valid conference JID if you don't have a conf server 12:07 < smcv> yeah 12:07 < smcv> perhaps have a flag TpChannelManagers can set for "it's ok, I don't need my handles normalized"? (If we want such a flag, we should probably add it at the same time.) The DTMF use-case is Bug #24902.