Bug 28118

Summary:	Should clear 'register' flag when an account is successfully registered.
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	mission-control	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-mission-control-smcv.git;a=shortlog;h=refs/heads/unregister
Whiteboard:	review+
i915 platform:		i915 features:

Description Will Thompson 2010-05-15 06:38:27 UTC

I just created a new account using Empathy, and it all worked and got signed in.

However, Mission Control (5.4.0-1) didn't clear the 'register' flag when the account first successfully signed in, so when I signed out and in again the account refuses to go online forever because “Name in use”.

I think MC should clear the 'register' flag when registration succeeds. (In fact I thought it already did...)

This is vaguely related to Empathy bugs <https://bugzilla.gnome.org/show_bug.cgi?id=600016>, <https://bugzilla.gnome.org/show_bug.cgi?id=567166> and <https://bugzilla.gnome.org/show_bug.cgi?id=598262>.

Comment 1 Simon McVittie 2010-06-07 11:38:56 UTC

This branch does as requested. We should probably backport to 5.4.x.

Comment 2 Guillaume Desmottes 2010-06-15 09:19:03 UTC

Why are you calling this function twice?
        _mcd_account_set_parameter (self, "register", NULL, NULL, NULL);

Comment 3 Simon McVittie 2010-06-15 09:53:20 UTC

(In reply to comment #2)
> Why are you calling this function twice?
>         _mcd_account_set_parameter (self, "register", NULL, NULL, NULL);

A typo. I've deleted the second call; anything else?

Comment 4 Simon McVittie 2010-06-15 12:01:47 UTC

review+ from cassidy until the merge from master. However, it turns out that when merged into master this no longer works, because _mcd_account_dup_parameters can now return params == NULL. I've made clear_register_dup_params_cb tolerate this.

Comment 5 Guillaume Desmottes 2010-06-16 03:55:23 UTC

Looks good.

Comment 6 Simon McVittie 2010-06-16 05:47:41 UTC

Fixed in git for 5.4.3 and 5.5.2.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.