Bug 28228

Summary:	Regression in 0.96 start-time handling
Product:	PolicyKit	Reporter:	Bastien Nocera <bugzilla>
Component:	daemon	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:	David Zeuthen (not reading bugmail) <zeuthen>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Bastien Nocera 2010-05-24 04:13:53 UTC

The "start-time" argument to a number of PolicyKit functions used to be optional, but the validation code added in:
http://cgit.freedesktop.org/PolicyKit/commit/?id=a72b5ba87920984caa74067fef0c01c500d96859
made it required.

The latest polkit-0.95-0.git20090913.3.fc12.x86_64 for Fedora 12 doesn't have that problem, but the latest one for Fedora 13 does.

The start-time, at least on Linux systems, should be gathered from /proc, as per this patch:
http://cgit.freedesktop.org/PolicyKit/commit/?id=50385761decb0a5a79c6cdc975b427c5918d7de3

Comment 1 Bastien Nocera 2010-05-24 04:15:14 UTC

This bug is causing errors like this one in gnome-lirc-properties:
https://bugzilla.gnome.org/show_bug.cgi?id=619389

Comment 2 David Zeuthen (not reading bugmail) 2010-05-26 13:22:09 UTC

(In reply to comment #0)
> The "start-time" argument to a number of PolicyKit functions used to be
> optional, but the validation code added in:

I'd rather not accept D-Bus subject structs for subject_kind 'unix-process' without the 'start-time' entry in the hash. (Actually the API docs never guaranteed you didn't have to provide it). Why can't you just make gnome-lirc-properties set the start-time entry itself? 

(If you want, we can amend the docs to document that 'start-time == 0' in the D-Bus API means 'look up in /proc etc.'. - that way g-l-p can just pass 0.)

Comment 3 Bastien Nocera 2010-05-26 13:55:23 UTC

(In reply to comment #2)
> (In reply to comment #0)
> > The "start-time" argument to a number of PolicyKit functions used to be
> > optional, but the validation code added in:
> 
> I'd rather not accept D-Bus subject structs for subject_kind 'unix-process'
> without the 'start-time' entry in the hash. (Actually the API docs never
> guaranteed you didn't have to provide it). Why can't you just make
> gnome-lirc-properties set the start-time entry itself? 
> 
> (If you want, we can amend the docs to document that 'start-time == 0' in the
> D-Bus API means 'look up in /proc etc.'. - that way g-l-p can just pass 0.)

The API supported "start-time" being absent, and it was that way for a whole release. Why did it suddenly become required? Reading the log for that commit, it really didn't seem like the point was to make "start-time" non-optional.

Comment 4 David Zeuthen (not reading bugmail) 2011-02-23 05:55:43 UTC

Looks like this was fixed in gnome-lirc-properties so closing here.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.