Bug 28239

Summary:	HandleWith should have a User_Action_Time argument
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	mission-control	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium	CC:	will
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/cassidy/telepathy-mission-control;a=shortlog;h=refs/heads/handle-time
Whiteboard:	review+ when spec supports it
i915 platform:		i915 features:
Bug Depends on:	25183
Bug Blocks:

Description Guillaume Desmottes 2010-05-25 06:42:48 UTC

+++ This bug was initially created as a clone of Bug #25183 +++

HandleWith() doesn't have a User_Action_Time argument so MC can't pass it on to HandleChannels() properly. Currently MC uses the time it got the HandleWith() call, but that's broken for noninteractive approvers.

We could add a HandleWithTime() variant.

Comment 1 Guillaume Desmottes 2010-05-25 06:54:05 UTC

Implemented in http://git.collabora.co.uk/?p=user/cassidy/telepathy-mission-control;a=shortlog;h=refs/heads/handle-time

Comment 2 Simon McVittie 2010-05-25 07:21:24 UTC

r+ conditional on spec and tp-glib releases. Since I'm likely to be the one making those releases, I'll merge it.

Comment 3 Simon McVittie 2010-05-25 10:27:06 UTC

Merged to master, will be in 5.5.0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.