Bug 28394

Summary: .desktop files in ~/Desktop need the execute bit set
Product: Portland Reporter: damjan.jov
Component: xdg-utilsAssignee: Portland Bugs <portland-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch to set the execute bit in xdg-desktop-icon

Description damjan.jov 2010-06-04 23:49:17 UTC 
Created attachment 36066 [details]
Patch to set the execute bit in xdg-desktop-icon

Hi

For security reasons, modern desktops ignore .desktop files in ~/Desktop that don't have the execute bit clear. These files give an error when double-clicked, and don't show the correct icon.

Thus to properly install a .desktop file to ~/Desktop, xdg-desktop-icon needs to set the execute bit. The attached patch does that.

Thank you
Damjan
Comment 1 Pablo Castellano (pablog) 2010-06-05 05:07:03 UTC 
Hello damjan.

Thanks for your patch but notice that you only have to modify the .in file as the other one is generated from that when you run 'make'.
Could you modify your patch?
Comment 2 Pablo Castellano (pablog) 2010-06-05 05:09:20 UTC 
Well, forget my comment. It seems that files are mixed.

patch looks good for me.
Comment 3 damjan.jov 2010-06-09 06:01:11 UTC 
Adding "patch" keyword.

When can I expect this to be committed? I've already found other bugs I want to patch that depend on this one. At what point can I apply for CVS write access?

Thank you
Damjan

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.