Summary: | Poppler-0.12.4 fails to compile due to _XOPEN_SOURCE on some OSX and Solaris | ||
---|---|---|---|
Product: | poppler | Reporter: | Fabian Groffen <grobian> |
Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED INVALID | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Fabian Groffen
2010-06-08 05:27:18 UTC
I don't know what you are compiling, but: * The fix for bug #27610 is not present on 0.12.4 so obviously is not the one at fault * _XOPEN_SOURCE is never unconditionally injected, only when you set DEFAULT_COMPILE_WARNINGS_KDE So i'd appreciate if you are a bit more specific of what you are using. ok, we've got this patch applied: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-text/poppler/files/poppler-0.12.4-xopen_source.patch?revision=1.1&view=markup Technically, that means indeed we are not on version 0.12.4 exact. However the patch is already committed, so next release will suffer from this. If DEFAULT_COMPILE_WARNINGS_KDE must be set, then the original bug (failure to compile on FreeBSD) would not be solved. I don't understand enough from cmake to judge if _XOPEN_SOURCE is injected based on DEFAULT_COMPILE_WARNINGS_KDE, or not, but since we don't seem to set it, which then means it's enabled by default. My observations in short: - FreeBSD needs _XOPEN_SOURCE=600 - OSX 10.4 and Solaris break on setting _XOPEN_SOURCE to any value - _XOPEN_SOURCE is only added when DEFAULT_COMPILE_WARNINGS_KDE, hence fix or breakage is conditional _XOPEN_SOURCE to 600 is only set when DEFAULT_COMPILE_WARNINGS_KDE is used, and that is not the default, so do not manually set DEFAULT_COMPILE_WARNINGS_KDE when compiling for some OSX and Solaris and be happy? I see there is another patch, never mind and sorry for the bother. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.